Re: Re: Re: Re: GSoC Project | Convert interactive rebase to C

From: Christian Couder <christian.couder@gmail.com>
Date: Mar 28, 2017, 06:27 UTC
Message-ID: <CAP8UFD0i8SV0S7ntpTLBLZF1rFRp-ExdOy=V_-v3eWX98BEqLg@mail.gmail.com>
In-Reply-To: <20170327163108.QoV1fm8z7%pickfire@riseup.net>

On Mon, Mar 27, 2017 at 6:31 PM, Pickfire <pickfire@riseup.net> wrote:

Show 27 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
>
>> On Sat, 25 Mar 2017, Ivan Tham wrote:
>>
>> > Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
>> > > On Tue, 21 Mar 2017, Ivan Tham wrote:
>> > > > Stefan Beller <sbeller@google.com> wrote:
>> > > > > On Mon, Mar 20, 2017 at 9:41 AM, Ivan Tham <pickfire@riseup.net> wrote:
>> > > > >
>> > > > > > I am interested to work on "Convert interactive rebase to C"
>> > > > >
>> > > > > +cc Johannes, who recently worked on rebase and the sequencer.
>> > >
>> > > Glad you are interested! Please note that large parts of the
>> > > interactive rebase are already in C now, but there is enough work left
>> > > in that corner.
>> >
>> > Glad to hear that, I would really like to see interactive rebase in C.
>>
>> Please note that a notable part already made it into C in v2.12.1. There
>> are still a few loose ends to tie, of course; it still makes for a great
>> head start on your project, methinks.
>
> Ah, that's great.
>
> And while I was working on the microproject (shell patterns in user diff),
> I can't produce the output of t/t4034-diff-words.sh manually with:

I don't think it's a good idea to discuss a microproject in the same thread where a project is discussed. I would suggest to move it in another thread where you describe in more details what you want to do and why, what you expect and what happened, and so on.

[...]

> That's does not just happens to cpp builtins, it happens to bibtex as well.
> Is it that I had missed some configuration since I have tested this on a
> few machines?

From a very quick look the problem seems related to how test_decode_color() is used or not.