Re: Re: GSoC Project | Convert interactive rebase to C

From: Stefan Beller <sbeller@google.com>
Date: Mar 23, 2017, 18:19 UTC
Message-ID: <CAGZ79kaR6FdoddiZXvSs+xYwGW4cS5r2EuLWNngA5a679puPNw@mail.gmail.com>
In-Reply-To: <alpine.DEB.2.20.1703231827060.3767@virtualbox>

On Thu, Mar 23, 2017 at 10:30 AM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 6 quoted lines

>> Are you sure about that? From what I had looked into userdiff.c, there
>> is no support for shell. There just a recent patch for [go patterns][0].
>> Or perhaps I should have rename it as "userdiff.c: patterns for "shell"
>> language"?
>
> I also could not find any shell patterns in the userdiff code...

Sorry for the confusion on my part. I am unfamiliar with that part of the diffing lib. I based my assumption on the output of "$ git log -p t/" which contains hunk headers, that make sense most of the time for shell code.

Show 10 quoted lines

>
> Careful. It is a ton of work to get the rebase -i conversion done, and
> then a ton of work to get it integrated. That will fill 3 months, very
> easily.
>
>> > > What do you think of these projects? Would it collide with Valery
>> > > Tolstov's Shell to Builtins proposal?
>
> I missed that proposal, and could only find submodule-related mails on the
> public-inbox server. Care to provide a pointer?

Well I don't think it is a full grown proposal, but a confident attempt to find a good starting point :) e.g. https://public-inbox.org/git/1489145258.10535.0@smtp.yandex.ru/

Show 5 quoted lines

>> > Curious why all people ask about colliding with Valerys proposal here?
>> > I do not think it would collide, as submodules and rebase are very
>> > different areas of the code base.
>
> Indeed ;-)

Although I had some discussion on what the correct behavior of "rebase --recurse-submodules" in a superproject should be. But this sounds like future work after the GSoC is over. ;)

Thanks, Stefan