Re: [RFC PATCH 4/4] name-rev: avoid naming from a ref if it’s not a descendant of any commit
- From
Christian Couder <christian.couder@gmail.com>
- Date
- Mar 3, 2019, 19:46 UTC
- Message-ID
- <CAP8UFD0bH--hLSXuc7Z9RN5oLNPWjVdCFS4+zeLo9qXTo93pxA@mail.gmail.com>
- In-Reply-To
- <CAP8UFD1HBbOX7wS664vBT8mxjGUJ4rtWYYJJX9RQqhN20-T8uA@mail.gmail.com>
On Sun, Mar 3, 2019 at 8:33 PM Christian Couder <christian.couder@gmail.com> wrote:
Show 20 quoted lines
> > On Fri, Mar 1, 2019 at 7:11 PM Alban Gruin <alban.gruin@gmail.com> wrote: > > > > A ref may not be the descendant of all of the commits mentionned in > > stdin. In this case, we want to avoid naming its parents. > > Properly speaking a ref usually just points to a commit. It is not a > parent or a descendant of any commit. > > Also if the commit, let's call it C, pointed to by a ref isn't a > descendant of a commit, let's call it C', mentioned on stdin, then C' > isn't a parent of C, though I think we want to avoid naming C' from > the ref. > > I think it might be clearer with something like: > > "The commit, let's call it C, pointed to by a ref may not be a > descendant of all the commits mentioned on stdin. In this case we want > to avoid naming the commits mentioned on stdin that are not parents of > C using the ref."
By the way things might even be clearer by replacing "parent" with "ancestor" in my message.