Re: [RFC PATCH 3/4] name-rev: check if a commit should be named before naming it

From: Alban Gruin <alban.gruin@gmail.com>
Date: Mar 1, 2019, 18:22 UTC
Message-ID: <992c5d7e-524a-3c92-9f0f-bbefbe151de5@gmail.com>
In-Reply-To: <CAPig+cQmZOWUZuj2+z+qrrCO-YBMNiEnGic1_FwAcaaj5gA5-w@mail.gmail.com>

Hi Eric,

Le 01/03/2019 à 19:05, Eric Sunshine a écrit :

Show 9 quoted lines

> On Fri, Mar 1, 2019 at 12:50 PM Alban Gruin <alban.gruin@gmail.com> wrote:
> -%<-
> Minor: It would probably be more efficient to check if the count is 0
> first, and only search the list if not.
> 
> By the way, how big is 'commits' likely to get? Will the linear scan
> done by commit_list_contains() become an issue? Should it be using a
> hash table instead?
>

It depends on the amount of commits mentionned in stdin that are reachable from the ref in name_ref(). If there is a lot of commit in the input, it may effectively become a problem.

I thought of adding a field to the rev_name structure for this purpose.
 I think commit slabs are hash maps under the hood?

Show 5 quoted lines

>> +                       name->tip_name = tip_name;
>> +                       free_alloc = 0;
>> +               } else {
>> +                       name->tip_name = NULL;
>> +               }

Cheers, Alban