Re: [PATCH v3 1/9] builtin/pack-objects: report reused packfile objects
- From
Christian Couder <christian.couder@gmail.com>
- Date
- Dec 11, 2019, 13:48 UTC
- Message-ID
- <CAP8UFD0YCSW_zDZ-OBif_MUBV3tkGR5554LSdFLkQGTegTxnqQ@mail.gmail.com>
- In-Reply-To
- <20191209062449.GA40570@coredump.intra.peff.net>
On Mon, Dec 9, 2019 at 7:24 AM Jeff King <peff@peff.net> wrote:
Show 18 quoted lines
> > On Fri, Nov 15, 2019 at 03:15:33PM +0100, Christian Couder wrote: > > > From: Jeff King <peff@peff.net> > > > > To see when packfile reuse kicks in or not, it is useful to > > show reused packfile objects statistics in the output of > > upload-pack. > > Yep, I think this one makes sense. I would be a bit curious to see how > often reuse actually kicks in for you with the current code. Back when I > worked on this topic in 2015, it was kicking in for us almost-never (at > least for big repos like torvalds/linux that we were interested in > measuring), but that's because we were packing all of the forks together > (and still do). The earlier heuristics made no sense for that case. > > I don't know if it's really worth spending a lot of time trying to > collect data, though.
Unfortunately it's not yet easy for me, or people in my team, to collect data from production servers. I will try to ping people about that though.