git/list[1] front-page[2] threads[3] people[4] search[5] about
 

"./t0001-init.sh --valgrind" is broken

From
Christian Couder <christian.couder@gmail.com>
Date
Mar 3, 2016, 00:07 UTC
Message-ID
<CAP8UFD0-FxoPe5-35NAKSkegFBoRPy1+BOsqN-y+QJUoXAqR3g@mail.gmail.com>
Hi,

It looks like commit 57ea7123c86771f47f34e7d92d1822d8b429897a (git.c: make sure we do not leak GIT_* to alias scripts, Dec 20 14:50:19 2015) broke "./t0001-init.sh --valgrind".

I get:
expecting success:
        (
                env | sed -ne "/^GIT_/s/=.*//p" &&
                echo GIT_PREFIX &&        # setup.c
                echo GIT_TEXTDOMAINDIR    # wrapper-for-bin.sh
        ) | sort | uniq >expected &&
        cat <<-\EOF >script &&
        #!/bin/sh
        env | sed -ne "/^GIT_/s/=.*//p" | sort >actual
        exit 0
        EOF
        chmod 755 script &&
        git config alias.script \!./script &&
        ( mkdir sub && cd sub && git script ) &&
        test_cmp expected actual

--- expected 2016-03-03 00:05:17.113754381 +0000 +++ actual 2016-03-03 00:05:19.041783583 +0000

@@ -10,7 +10,6 @@
 GIT_PREFIX
 GIT_TEMPLATE_DIR
 GIT_TEST_TEE_STARTED
-GIT_TEXTDOMAINDIR
 GIT_TRACE_BARE
 GIT_VALGRIND
 GIT_VALGRIND_ENABLED
not ok 6 - No extra GIT_* on alias scripts

It's late here so I don't have time to work on this tonight.

Thanks,
Christian.
Next: Duy Nguyen
Message 1 of 9 in “"./t0001-init.sh --valgrind" is broken”
  1. Christian CouderMar 3, 2016
  2. Duy NguyenMar 3, 2016
  3. Junio C HamanoMar 3, 2016
  4. Johannes SixtMar 3, 2016
  5. Duy NguyenMar 3, 2016
  6. Duy NguyenMar 3, 2016
  7. Junio C HamanoMar 3, 2016
  8. Jeff KingMar 3, 2016
  9. Johannes SixtMar 3, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.