Re: "./t0001-init.sh --valgrind" is broken
- From
Duy Nguyen <pclouds@gmail.com>
- Date
- Mar 3, 2016, 12:16 UTC
- Message-ID
- <CACsJy8AE9VovwuviwOLxRDTAbTXCivRVhk8ia4mdUnMN-0Y4OA@mail.gmail.com>
- In-Reply-To
- <CACsJy8CVfJdCmwWo50wHsc6DP6ft71d5bfBaFSJpv9XcNRwdSQ@mail.gmail.com>
On Thu, Mar 3, 2016 at 7:09 PM, Duy Nguyen <pclouds@gmail.com> wrote:
> But it's probably better that we inject valgrind command > from inside bin-wrappers script, the same way we inject gdb, I think.
For the best of both worlds, we should recreate bin-wrappers in test-lib.sh (i.e. the valgrind way), not in Makefile. Somewhat unrelated, but because topdir is getting really crowded and bin-wrappers is used for the test suite only, it should be moved inside t/ (i'm going to move all test-* to t/ too, later).
-- Duy