Re: [PATCH] builtin: pass repository to sub commands

From: Christian Couder <christian.couder@gmail.com>
Date: Nov 26, 2024, 08:46 UTC
Message-ID: <CAP8UFD0=OycMAaDi_92-Go2Mt4q-s7cfmBaZD_kWBnZsvYpiPA@mail.gmail.com>
In-Reply-To: <20241125-374-add-repository-to-subsubcommands-v1-1-637a5e22ba48@gmail.com>

On Mon, Nov 25, 2024 at 3:56 PM Karthik Nayak <karthik.188@gmail.com> wrote:

Show 12 quoted lines

>
> In 9b1cb5070f (builtin: add a repository parameter for builtin
> functions, 2024-09-13) the repository was passed down to all builtin
> commands. This allowed the repository to be passed down to lower layers
> without depending on the global `the_repository` variable.
>
> Continue this work by also passing down the repository parameter from
> the command to sub-commands. This will help pass down the repository to
> other subsystems and cleanup usage of global variables like
> 'the_repository' and 'the_hash_algo'.
>
> Signed-off-by: Karthik Nayak <karthik.188@gmail.com>

Yeah, this is definitely needed to cleanup usage of global variables, and looks well done to me. Ack.

Thanks.