Re: [PATCH v2] builtin: allow passing custom data to sub-commands

From: karthik nayak <karthik.188@gmail.com>
Date: Nov 27, 2024, 09:15 UTC
Message-ID: <CAOLa=ZQgKv4SEPRqQix8pJo1nr30Fpg2oF-LdDX1ynHeSjDcGw@mail.gmail.com>
In-Reply-To: <xmqqy115x0be.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 10 quoted lines

> karthik nayak <karthik.188@gmail.com> writes:
>
>> Could you elaborate on why you think this is an over-optimization? We
>> don't loose functionality with this, nor do we have to have add
>> additional code to handle the typecasting to `struct repository *` if
>> needed. But would definitely like to resolve anything I missed.
>
> I do not know if it is an optimization, but if you know it is of a
> specific type, casting back and force with "void *" loses type
> safety, no?

That is true of course, I just thought that is the price to pay in C for having to deal with generic data propagation. In the end I'm okay with both scenarios, I see merits both ways. I do tend to incline on the generic version in v2, since it is a lot more expandable.