Re: [PATCH/RFC 2/2] git-p4: Add complex test case for branch import

From: Vitor Antunes <vitor.hda@gmail.com>
Date: Aug 24, 2011, 10:46 UTC
Message-ID: <CAOpHH-V9nm2NRD47gdUj6sLJSTypjABjE-JGCkADE=fxh2nSWg@mail.gmail.com>
In-Reply-To: <20110823231034.GA11918@arf.padd.com>

On Wed, Aug 24, 2011 at 12:10 AM, Pete Wyckoff <pw@padd.com> wrote:

Show 5 quoted lines

> Nice analysis.  P4 can indeed be the bottleneck, even on near
> servers if there are lots of files.  Diff-tree seems like the
> better choice to find the branch point.  I don't understand fully
> why the way we are using fast-import causes these problems.  Will
> look at that next.

I came up with some ideas during sleep:

1. When doing a "checkpoint" it would make sense to have some kind of
   feedback loop to know when fast-import completes it. In fact, I've
   just looked at fast-import man page and the "progress" command seems
   to do exactly that! Myabe we should crease a specific function for
   "checkpoint" that would call also "progress" instead of calling
   os.sleep().

2. In order to avoid needing to use "--force" it would be nice to have
   some form of "drop" command in fast-import that would allows us to
   actively drop an older commit after calling "reset" (this could even
   be an option of "reset"). This way fast-import would not find
   dangling commits in the end of the import.  Maybe there's already
   some sort of command to achieve this in fast-import...? We could
   probably ask to one of its maintainers.

-- 
Vitor Antunes