Re: [PATCH/RFC 2/2] git-p4: Add complex test case for branch import

From: Vitor Antunes <vitor.hda@gmail.com>
Date: Aug 24, 2011, 21:23 UTC
Message-ID: <CAOpHH-Uv=zK9JoL+ooA9eEHg2XyX=k92hL1QZ_WNZwgvpnNj0g@mail.gmail.com>
In-Reply-To: <CAOpHH-V9nm2NRD47gdUj6sLJSTypjABjE-JGCkADE=fxh2nSWg@mail.gmail.com>

On Wed, Aug 24, 2011 at 11:46 AM, Vitor Antunes <vitor.hda@gmail.com> wrote:

Show 6 quoted lines

> 1. When doing a "checkpoint" it would make sense to have some kind of
>   feedback loop to know when fast-import completes it. In fact, I've
>   just looked at fast-import man page and the "progress" command seems
>   to do exactly that! Myabe we should crease a specific function for
>   "checkpoint" that would call also "progress" instead of calling
>   os.sleep().

    # Force a checkpoint in fast-import and wait for it to finish
    def checkpoint(self):
        self.gitStream.write("checkpoint\n\n")
        self.gitStream.write("progress checkpoint\n\n")
        out = self.gitOutput.readline()
        if self.verbose:
            print "checkpoint finished: " + out

This seems to work! :)

Show 7 quoted lines

> 2. In order to avoid needing to use "--force" it would be nice to have
>   some form of "drop" command in fast-import that would allows us to
>   actively drop an older commit after calling "reset" (this could even
>   be an option of "reset"). This way fast-import would not find
>   dangling commits in the end of the import.  Maybe there's already
>   some sort of command to achieve this in fast-import...? We could
>   probably ask to one of its maintainers.

Just missing point 2 now.

-- 
Vitor Antunes