git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [BUG] git-check-ignore: Segmentation fault

From
Adam Spiers <git@adamspiers.org>
Date
Feb 19, 2013, 13:40 UTC
Message-ID
<CAOkDyE_96Ef5CjoxNk3mbsNi+ZAuv6XeHcO7r8RQ-Of5ELsuKw@mail.gmail.com>
In-Reply-To
<CAKJhZwR7AT6VfCZYwaTvWYyjtYWg+RxBSmB5NaJY0LrqMUnD6A@mail.gmail.com>

On Tue, Feb 19, 2013 at 5:24 AM, Zoltan Klinger <zoltan.klinger@gmail.com> wrote:

Show 26 quoted lines
> Hi there,
>
> The new git-check-ignore command seg faults when
>     (1) it is called with single dot path name at $GIT_DIR level  _AND_
>     (2) and .gitignore has at least one directory pattern.
>
> Git version: 1.8.2.rc0.16.g20a599e
>
> Reproduce the bug:
>     $ git --version
>     git version 1.8.2.rc0.16.g20a599e
>     $ mkdir test
>     $ cd test
>     $ git init
>     $ git check-ignore .  # All good, no errors here
>     $ echo "dirpattern/" > .gitignore
>     $ git check-ignore .
>     Segmentation fault (core dumped)
>
> The segmentation fault is actually caused by hash_name(const char
> *name, int namelen) function in name-hash.c when the 'name' argument
> is an empty stringi and namelen is 0.
>
> The empty string comes from a call to the prefix_path(prefix, len,
> path) function in setup.c. In this instance arguments 'prefix' is
> NULL, 'len' is 0 and 'path' is "." .

Good catch! Thanks for the very helpful bug report. I can reproduce this, and have a fix - see follow-up mail to follow shortly.

Previous: Zoltan KlingerNext: Adam Spiers
Message 2 of 27 in “[BUG] git-check-ignore: Segmentation fault”
  1. Zoltan KlingerFeb 19, 2013
  2. Adam SpiersFeb 19, 2013
  3. 1/2 t0008: document test_expect_success_multiAdam Spiers, Feb 19, 2013
  4. 2/2 check-ignore.c: fix segfault with '.' argument from repo rootAdam Spiers, Feb 19, 2013
  5. Junio C HamanoFeb 19, 2013
  6. Adam SpiersFeb 19, 2013
  7. 2/2 check-ignore.c, dir.c: fix segfault with '.' argument from repo rootAdam Spiers, Feb 19, 2013
  8. Junio C HamanoFeb 19, 2013
  9. Junio C HamanoFeb 19, 2013
  10. Adam SpiersFeb 20, 2013
  11. Junio C HamanoFeb 20, 2013
  12. Adam SpiersFeb 20, 2013
  13. Adam SpiersFeb 20, 2013
  14. Re* [PATCH 2/2] check-ignore.c: fix segfault with '.' argument from repo rootJunio C Hamano, Feb 19, 2013
  15. Adam SpiersFeb 20, 2013
  16. Junio C HamanoFeb 20, 2013
  17. Adam SpiersFeb 20, 2013
  18. Junio C HamanoFeb 21, 2013
  19. 1/2 format-patch: rename "no_inline" fieldJunio C Hamano, Feb 21, 2013
  20. 2/2 format-patch: --inline-singleJunio C Hamano, Feb 21, 2013
  21. Jeff KingFeb 21, 2013
  22. Junio C HamanoFeb 21, 2013
  23. Junio C HamanoFeb 21, 2013
  24. Adam SpiersFeb 22, 2013
  25. Junio C HamanoFeb 22, 2013
  26. Jeff KingFeb 22, 2013
  27. Junio C HamanoFeb 19, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.