git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Re* [PATCH 2/2] check-ignore.c: fix segfault with '.' argument from repo root

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 20, 2013, 02:53 UTC
Message-ID
<7vppzv3dd8.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20130220020046.GC7860@pacific.linksys.moosehall>
Adam Spiers <git@adamspiers.org> writes:
> OK, thanks for the information.  IMHO it would be nice if 'git
> format-patch' and 'git am' supported this style of inline patch
> inclusion, but maybe there are good reasons to discourage it?

"git am --scissors" is a way to process such e-mail where the patch submitter continues discussion in the top part of a message, concludes the message with:

	A patch to do so is attached.
	-- >8 --

and then tells the MUA to read in an output from format-patch into the e-mail buffer. You still need to strip out unneeded headers like the "From ", "From: " and "Date: " lines when you add the scissors anyway, and this is applicable only for a single-patch series, so the "feature" does not fit well as a format-patch option.

Previous: Adam SpiersNext: Adam Spiers
Message 16 of 27 in “[BUG] git-check-ignore: Segmentation fault”
  1. Zoltan KlingerFeb 19, 2013
  2. Adam SpiersFeb 19, 2013
  3. 1/2 t0008: document test_expect_success_multiAdam Spiers, Feb 19, 2013
  4. 2/2 check-ignore.c: fix segfault with '.' argument from repo rootAdam Spiers, Feb 19, 2013
  5. Junio C HamanoFeb 19, 2013
  6. Adam SpiersFeb 19, 2013
  7. 2/2 check-ignore.c, dir.c: fix segfault with '.' argument from repo rootAdam Spiers, Feb 19, 2013
  8. Junio C HamanoFeb 19, 2013
  9. Junio C HamanoFeb 19, 2013
  10. Adam SpiersFeb 20, 2013
  11. Junio C HamanoFeb 20, 2013
  12. Adam SpiersFeb 20, 2013
  13. Adam SpiersFeb 20, 2013
  14. Re* [PATCH 2/2] check-ignore.c: fix segfault with '.' argument from repo rootJunio C Hamano, Feb 19, 2013
  15. Adam SpiersFeb 20, 2013
  16. Junio C HamanoFeb 20, 2013
  17. Adam SpiersFeb 20, 2013
  18. Junio C HamanoFeb 21, 2013
  19. 1/2 format-patch: rename "no_inline" fieldJunio C Hamano, Feb 21, 2013
  20. 2/2 format-patch: --inline-singleJunio C Hamano, Feb 21, 2013
  21. Jeff KingFeb 21, 2013
  22. Junio C HamanoFeb 21, 2013
  23. Junio C HamanoFeb 21, 2013
  24. Adam SpiersFeb 22, 2013
  25. Junio C HamanoFeb 22, 2013
  26. Jeff KingFeb 22, 2013
  27. Junio C HamanoFeb 19, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.