Re: [PATCH v6 0/7] make test output coloring more intuitive

From: Adam Spiers <git@adamspiers.org>
Date: Dec 20, 2012, 18:08 UTC
Message-ID: <CAOkDyE-yfFQxxgsumRB8N1zXN2LTq89=pArU-85Z+3Oyruiwxg@mail.gmail.com>
In-Reply-To: <20121220161110.GA10605@sigill.intra.peff.net>

On Thu, Dec 20, 2012 at 4:11 PM, Jeff King <peff@peff.net> wrote:

Show 22 quoted lines

> On Thu, Dec 20, 2012 at 03:44:53PM +0000, Adam Spiers wrote:
>> > diff --git a/t/test-lib.sh b/t/test-lib.sh
>> > index 256f1c6..31f59af 100644
>> > --- a/t/test-lib.sh
>> > +++ b/t/test-lib.sh
>> > @@ -227,7 +227,7 @@ then
>> >                 pass)
>> >                         tput setaf 2;;            # green
>> >                 info)
>> > -                       tput bold; tput setaf 6;; # bold cyan
>> > +                       tput setaf 6;; # cyan
>> >                 *)
>> >                         test -n "$quiet" && return;;
>> >                 esac
>> >
>>
>> Good point, I forgot to check what it looked like with -v.  Since this
>> series is already on v6, is there a more lightweight way of addressing
>> this tiny tweak than sending v7?
>
> It is ultimately up to Junio, but I suspect he would be OK if you just
> reposted patch 4/7 with the above squashed.

I'll do that if Junio is OK with that.

> Or even just said "I like
> this, please squash it into patch 4 (change info messages from
> yellow/brown to bold cyan).

Yes, I'm OK with this way too :) Of course "bold" would need to be dropped from the commit message.