[PATCH v6 2/7] tests: paint known breakages in bold yellow
- From
Adam Spiers <git@adamspiers.org>
- Date
- Dec 16, 2012, 18:28 UTC
- Message-ID
- <1355682495-22382-3-git-send-email-git@adamspiers.org>
- In-Reply-To
- <1355682495-22382-1-git-send-email-git@adamspiers.org>
Bold yellow seems a more appropriate color than bold green when considering the universal traffic lights coloring scheme, where green conveys the impression that everything's OK, and amber that something's not quite right.
Likewise, change the color of the summarized total number of known breakages from bold red to bold yellow to be less alarmist and more consistent with the above.
Signed-off-by: Adam Spiers <git@adamspiers.org> --- t/test-lib.sh | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/t/test-lib.sh b/t/test-lib.sh index d0b236f..710f051 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -213,6 +213,8 @@ then tput bold; tput setaf 1;; # bold red skip) tput bold; tput setaf 2;; # bold green + warn) + tput bold; tput setaf 3;; # bold brown/yellow pass) tput setaf 2;; # green info) @@ -311,7 +313,7 @@ test_known_broken_ok_ () { test_known_broken_failure_ () { test_broken=$(($test_broken+1)) - say_color skip "not ok $test_count - $@ # TODO known breakage" + say_color warn "not ok $test_count - $@ # TODO known breakage" } test_debug () { @@ -408,7 +410,7 @@ test_done () { fi if test "$test_broken" != 0 then - say_color error "# still have $test_broken known breakage(s)" + say_color warn "# still have $test_broken known breakage(s)" msg="remaining $(($test_count-$test_broken)) test(s)" else msg="$test_count test(s)"
-- 1.7.12.1.396.g53b3ea9