Re: [msysGit] [PATCH] gitk: fix the display of files when filtered by path

From: Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
Date: Dec 15, 2011, 19:42 UTC
Message-ID: <CAOeW2eHD7Xutf+pHDyMOo=uZC9PSFZi+aMq1Rx80iTKPFApr8A@mail.gmail.com>
In-Reply-To: <alpine.DEB.1.00.1112151023280.2615@bonsai2>

Hi,

On Thu, Dec 15, 2011 at 1:24 AM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 12 quoted lines

> Hi,
>
> On Wed, 14 Dec 2011, David Aguilar wrote:
>
>> On Tue, Dec 13, 2011 at 8:50 AM, Pat Thoyts
>> <patthoyts@users.sourceforge.net> wrote:
>> > Launching 'gitk -- .' or 'gitk -- ..\t' restricts the display to files
>> > under the given directory but the file list is left empty. This is because
>> > the path_filter function fails to match the filenames which are relative
>> > to the working tree to the filter which is filessytem relative.
>> > This solves the problem by making both names fully qualified filesystem
>> > paths before performing the comparison.

How is this related to my patches from April? See http://thread.gmane.org/gmane.comp.version-control.git/170853. It's clearly not the same problem, but will the patches conflict? Will some of mine be unnecessary?

> Thanks for reminding me that I did not yet apply and push. Did so now.

What do you mean by this? Push to where? git://git.kernel.org/pub/scm/gitk/gitk.git is still down.

Paul and Junio, the patches I sent in April are still not in git.git, are they? Can we use another repo until the kernel.org one is up? More than eight months to get a patch (or eight) merged is way too long, IMO.

Martin