git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [msysGit] [PATCH] gitk: fix the display of files when filtered by path

From
David Aguilar <davvid@gmail.com>
Date
Dec 15, 2011, 04:18 UTC
Message-ID
<CAJDDKr6rVaX_=SZZeEAs950yuNDvi8sOkzrUK7LnCrK6MYfscg@mail.gmail.com>
In-Reply-To
<87hb14wg4l.fsf@fox.patthoyts.tk>

On Tue, Dec 13, 2011 at 8:50 AM, Pat Thoyts <patthoyts@users.sourceforge.net> wrote:

Show 8 quoted lines
> Launching 'gitk -- .' or 'gitk -- ..\t' restricts the display to files
> under the given directory but the file list is left empty. This is because
> the path_filter function fails to match the filenames which are relative
> to the working tree to the filter which is filessytem relative.
> This solves the problem by making both names fully qualified filesystem
> paths before performing the comparison.
>
> Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
Wonderful!

I've run into this problem a number of times (as have some co-workers) but I never bothered to report it since I felt guilty for never having worked up a patch.

I tested this and it worked.
FWIW,
Tested-by: David Aguilar <davvid@gmail.com>
Thank you Pat!
-- 
            David
Previous: Pat ThoytsNext: Johannes Schindelin
Message 2 of 12 in “gitk: fix the display of files when filtered by path”
  1. gitk: fix the display of files when filtered by pathPat Thoyts, Dec 13, 2011
  2. David AguilarDec 15, 2011
  3. Johannes SchindelinDec 15, 2011
  4. Martin von ZweigbergkDec 15, 2011
  5. Junio C HamanoDec 15, 2011
  6. Pat ThoytsDec 15, 2011
  7. Jakub NarebskiDec 16, 2011
  8. Paul MackerrasDec 15, 2011
  9. Pat ThoytsDec 15, 2011
  10. Paul MackerrasDec 15, 2011
  11. Junio C HamanoDec 17, 2011
  12. Paul MackerrasMar 18, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.