git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] remove unnecessary parameter from get_patch_ids()

From
Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
Date
Jul 28, 2012, 01:54 UTC
Message-ID
<CAOeW2eG_5G3qQTguvWsSDfLU1s5p=B8WT=v8ywe=G1-VJTfGNw@mail.gmail.com>
In-Reply-To
<7v1ujwzuw1.fsf@alter.siamese.dyndns.org>
On Fri, Jul 27, 2012 at 3:44 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Martin von Zweigbergk <martin.von.zweigbergk@gmail.com> writes:
>
> s/it seems the prefix doesn't change/the prefix never changes/;
:-) Thanks for confirming.
> In that sense it probably does not even matter if you did not pass
> rev->prefix down to check_rev, and instead gave NULL to it, but that
> only holds true in the current codebase, so I think what your patch
> does is the right thing to do.
Makes sense. Thanks for explaining!
Previous: Junio C HamanoNext: Martin von Zweigbergk
Message 4 of 10 in “Small log simplifications”
  1. 0/2 Small log simplificationsMartin von Zweigbergk, Jul 27, 2012
  2. 1/2 remove unnecessary parameter from get_patch_ids()Martin von Zweigbergk, Jul 27, 2012
  3. Junio C HamanoJul 27, 2012
  4. Martin von ZweigbergkJul 28, 2012
  5. 2/2 log: remove redundant check for merge commitMartin von Zweigbergk, Jul 27, 2012
  6. Junio C HamanoJul 27, 2012
  7. Martin von ZweigbergkJul 28, 2012
  8. Junio C HamanoJul 28, 2012
  9. Martin von ZweigbergkJul 29, 2012
  10. Junio C HamanoJul 29, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.