From: Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
Date: Sat, 28 Jul 2012 01:54:50 GMT
Subject: Re: [PATCH 1/2] remove unnecessary parameter from get_patch_ids()
Message-ID: <CAOeW2eG_5G3qQTguvWsSDfLU1s5p=B8WT=v8ywe=G1-VJTfGNw@mail.gmail.com>
In-Reply-To: <7v1ujwzuw1.fsf@alter.siamese.dyndns.org>

On Fri, Jul 27, 2012 at 3:44 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Martin von Zweigbergk <martin.von.zweigbergk@gmail.com> writes:
>
> s/it seems the prefix doesn't change/the prefix never changes/;

:-) Thanks for confirming.

> In that sense it probably does not even matter if you did not pass
> rev->prefix down to check_rev, and instead gave NULL to it, but that
> only holds true in the current codebase, so I think what your patch
> does is the right thing to do.

Makes sense. Thanks for explaining!