git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] userdiff: add support for R programming language

From
Rodrigo Carvalho <rodrigorsdc@gmail.com>
Date
May 29, 2025, 21:36 UTC
Message-ID
<CAOeBkLo-Df7p-ndr06vA8MGHd42GEB6X3i66PnBt=MrQk7GJjw@mail.gmail.com>
In-Reply-To
<xmqq4ix6rt75.fsf@gitster.g>
Show 7 quoted lines
> > This singles out identifiers. Every single other characters would be its
> > own word. I'd consider this a disimprovement. If you are not prepared to
> > provide worddiff patterns, I recommend to use "[^ \t]+", which roughly
> > amounts to the default behavior. It can be improved incrementally in
> > later patches.
>
> Good point.
Thanks for the remark. I'll change to this approach in v2
Show 5 quoted lines
> > Please squash the test cases into this patch. Don't forget to test an
> > indented function, and while at it, test a function definition *nested*
> > in a function definition: that documents what the expected outcome is.
>
> Again, good point.

Sure, that is an important feature that a userdiff driver should address. Thanks again

Previous: Junio C HamanoNext: Rodrigo Carvalho
Message 6 of 9 in “userdiff: add support for R programming language”
  1. 1/2 userdiff: add support for R programming languageRodrigo Carvalho, May 25, 2025
  2. 2/2 t4018: add two userdiff tests for R languageRodrigo Carvalho, May 25, 2025
  3. Eric SunshineMay 25, 2025
  4. Johannes SixtMay 26, 2025
  5. Junio C HamanoMay 27, 2025
  6. Rodrigo CarvalhoMay 29, 2025
  7. userdiff: add support for R programming languageRodrigo Carvalho, May 29, 2025
  8. Junio C HamanoJun 3, 2025
  9. Johannes SixtJun 3, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.