From: Rodrigo Carvalho <rodrigorsdc@gmail.com>
Date: Thu, 29 May 2025 21:36:50 GMT
Subject: Re: [PATCH 1/2] userdiff: add support for R programming language
Message-ID: <CAOeBkLo-Df7p-ndr06vA8MGHd42GEB6X3i66PnBt=MrQk7GJjw@mail.gmail.com>
In-Reply-To: <xmqq4ix6rt75.fsf@gitster.g>

> > This singles out identifiers. Every single other characters would be its
> > own word. I'd consider this a disimprovement. If you are not prepared to
> > provide worddiff patterns, I recommend to use "[^ \t]+", which roughly
> > amounts to the default behavior. It can be improved incrementally in
> > later patches.
>
> Good point.

Thanks for the remark. I'll change to this approach in v2


> > Please squash the test cases into this patch. Don't forget to test an
> > indented function, and while at it, test a function definition *nested*
> > in a function definition: that documents what the expected outcome is.
>
> Again, good point.

Sure, that is an important feature that a userdiff driver should
address. Thanks again