Re: [PATCH v1] annotate: skip checking working tree if a revision is provided

From: Edmundo Carmona Antoranz <eantoranz@gmail.com>
Date: Nov 21, 2015, 01:25 UTC
Message-ID: <CAOc6etbF-yF0bhmmjQG=P=FW0QnokPTXnqLiyPM7uJ7eqom9rw@mail.gmail.com>
In-Reply-To: <1447809609-17556-1-git-send-email-eantoranz@gmail.com>

On Tue, Nov 17, 2015 at 7:20 PM, Edmundo Carmona Antoranz <eantoranz@gmail.com> wrote:

> +       if (!revs.pending.nr && !file_exists(path))
> +               die_errno("cannot stat path '%s'", path);
> +

I was wondering if I should only check the path that is coming from "blame" (which is where I'm taking the check from) by checking dashdash_pos:

if (!dashdash_pos && !revs.pending.nr && !file_exists(path))
    die_errno("cannot stat path '%s'", path);

So that we don't apply the check if we are coming from normal dashdash_pos != 0 (and which didn't apply the filesystem check).

Thanks in advance.