Re: [PATCH v1] annotate: skip checking working tree if a revision is provided

From: Edmundo Carmona Antoranz <eantoranz@gmail.com>
Date: Nov 21, 2015, 01:40 UTC
Message-ID: <CAOc6etYzxbY9SR7aegTdqo9RB8bcRoL9ihZZDP3rDZVUwDT6BA@mail.gmail.com>
In-Reply-To: <CAOc6etbF-yF0bhmmjQG=P=FW0QnokPTXnqLiyPM7uJ7eqom9rw@mail.gmail.com>

And I did't say it right. The execution path where dashdash_pos is 0 is coming from "annotate". Sorry for my confusion on the previous mail.

On Fri, Nov 20, 2015 at 7:25 PM, Edmundo Carmona Antoranz <eantoranz@gmail.com> wrote:

Show 17 quoted lines

> On Tue, Nov 17, 2015 at 7:20 PM, Edmundo Carmona Antoranz
> <eantoranz@gmail.com> wrote:
>> +       if (!revs.pending.nr && !file_exists(path))
>> +               die_errno("cannot stat path '%s'", path);
>> +
>
> I was wondering if I should only check the path that is coming from
> "blame" (which is where I'm taking the check from) by checking
> dashdash_pos:
>
> if (!dashdash_pos && !revs.pending.nr && !file_exists(path))
>     die_errno("cannot stat path '%s'", path);
>
> So that we don't apply the check if we are coming from normal
> dashdash_pos != 0 (and which didn't apply the filesystem check).
>
> Thanks in advance.