git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v1] builtin/checkout.c: replace bit-shift values for macros in call to check_stages

From
Edmundo Carmona Antoranz <eantoranz@gmail.com>
Date
Jun 7, 2020, 05:54 UTC
Message-ID
<CAOc6etZGw5SUj_ijWZtDjN44i7WLMKrUKALCpmfPAPxZK1c-tw@mail.gmail.com>
In-Reply-To
<20200607054849.1014185-1-eantoranz@gmail.com>

On Sat, Jun 6, 2020 at 11:49 PM Edmundo Carmona Antoranz <eantoranz@gmail.com> wrote:

Show 7 quoted lines
>
> Currently a call to check_stages is using bit-shift values to define what will be used
> as the first argument. If the reader doesn't know what the values are from heart, they
> have to go dig in cache.h what each value is.
>
> This patch is replacing those values for the macros from cache.h so that it's
> clear at first sight what they are (CE_ENTRY_REMOVED, CE_ENTRY_ADDED)

The macros are defined since at least v2.1.0 and I am able to apply the patch on top of it. Should I send the patch from that version? I am sending on top of v2.22.4 cause it's the oldest version I was able to compile successfully.

Previous: Edmundo Carmona AntoranzNext: Junio C Hamano
Message 2 of 4 in “builtin/checkout.c: replace bit-shift values for macros in call to check_stages”
  1. builtin/checkout.c: replace bit-shift values for macros in call to check_stagesEdmundo Carmona Antoranz, Jun 7, 2020
  2. Edmundo Carmona AntoranzJun 7, 2020
  3. Junio C HamanoJun 9, 2020
  4. Edmundo Carmona AntoranzJun 10, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.