From: Edmundo Carmona Antoranz <eantoranz@gmail.com>
Date: Sun, 07 Jun 2020 05:54:06 GMT
Subject: Re: [PATCH v1] builtin/checkout.c: replace bit-shift values for macros in call to check_stages
Message-ID: <CAOc6etZGw5SUj_ijWZtDjN44i7WLMKrUKALCpmfPAPxZK1c-tw@mail.gmail.com>
In-Reply-To: <20200607054849.1014185-1-eantoranz@gmail.com>

On Sat, Jun 6, 2020 at 11:49 PM Edmundo Carmona Antoranz
<eantoranz@gmail.com> wrote:
>
> Currently a call to check_stages is using bit-shift values to define what will be used
> as the first argument. If the reader doesn't know what the values are from heart, they
> have to go dig in cache.h what each value is.
>
> This patch is replacing those values for the macros from cache.h so that it's
> clear at first sight what they are (CE_ENTRY_REMOVED, CE_ENTRY_ADDED)


The macros are defined since at least v2.1.0 and I am able to apply
the patch on top of it. Should
I send the patch from that version? I am sending on top of v2.22.4
cause it's the oldest version I
was able to compile successfully.