git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v1] blame: add support for --[no-]progress option

From
Edmundo Carmona Antoranz <eantoranz@gmail.com>
Date
Nov 22, 2015, 15:56 UTC
Message-ID
<CAOc6etYXHjGRT7dBsP835VntTQL2NyQnYTQXwbzreBR-5sSiSQ@mail.gmail.com>
In-Reply-To
<CAOc6etbfzrqT4-5dorCAq_=5Oh9wXV4LgRwK9hrEqjmSYHiBEg@mail.gmail.com>

On Sat, Nov 21, 2015 at 11:27 PM, Edmundo Carmona Antoranz <eantoranz@gmail.com> wrote:

Show 5 quoted lines
> -static void assign_blame(struct scoreboard *sb, int opt)
> +static void assign_blame(struct scoreboard *sb, int opt, int show_progress)
>
> Would it be better to include show_progress as a binary flag in opt
> instead of a separate variable?
What is the point of having 'global' variable and not using it as such?

I'm sending a second version of the patch where I'm taking care of most of my previous comments. Let's hope that one holds water.

Thanks in advance.
Previous: Edmundo Carmona Antoranz
Message 4 of 4 in “blame: add support for --[no-]progress option”
  1. blame: add support for --[no-]progress optionEdmundo Carmona Antoranz, Nov 22, 2015
  2. Edmundo Carmona AntoranzNov 22, 2015
  3. Edmundo Carmona AntoranzNov 22, 2015
  4. Edmundo Carmona AntoranzNov 22, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.