From: Edmundo Carmona Antoranz <eantoranz@gmail.com>
Date: Sun, 22 Nov 2015 15:56:14 GMT
Subject: Re: [PATCH v1] blame: add support for --[no-]progress option
Message-ID: <CAOc6etYXHjGRT7dBsP835VntTQL2NyQnYTQXwbzreBR-5sSiSQ@mail.gmail.com>
In-Reply-To: <CAOc6etbfzrqT4-5dorCAq_=5Oh9wXV4LgRwK9hrEqjmSYHiBEg@mail.gmail.com>

On Sat, Nov 21, 2015 at 11:27 PM, Edmundo Carmona Antoranz
<eantoranz@gmail.com> wrote:
> -static void assign_blame(struct scoreboard *sb, int opt)
> +static void assign_blame(struct scoreboard *sb, int opt, int show_progress)
>
> Would it be better to include show_progress as a binary flag in opt
> instead of a separate variable?

What is the point of having 'global' variable and not using it as such?

I'm sending a second version of the patch where I'm taking care of
most of my previous comments. Let's hope that one holds water.

Thanks in advance.