Re: [PATCH v6] blame: add support for --[no-]progress option

From: Edmundo Carmona Antoranz <eantoranz@gmail.com>
Date: Dec 13, 2015, 00:01 UTC
Message-ID: <CAOc6etYBaiAhEjZTn2knCe+HywjqFN5qhQtHFBwRAC2r_iBsJQ@mail.gmail.com>
In-Reply-To: <1449964625-27737-1-git-send-email-eantoranz@gmail.com>

On Sat, Dec 12, 2015 at 5:57 PM, Edmundo Carmona Antoranz <eantoranz@gmail.com> wrote:

Show 7 quoted lines

> +       if (incremental || (output_option & OUTPUT_PORCELAIN)) {
> +               if (show_progress > 0)
> +                       die("--progress can't be used with --incremental or porcelain formats");
> +               show_progress = 0;
> +       } else if (show_progress < 0)
> +               show_progress = isatty(2);
> +

I think I took care of all the comments from Eric gracefully. Hope that block is ok for detection of mutually exclusivity related to --progress.

Cheers!