From: Edmundo Carmona Antoranz Date: Sun, 13 Dec 2015 00:01:05 GMT Subject: Re: [PATCH v6] blame: add support for --[no-]progress option Message-ID: In-Reply-To: <1449964625-27737-1-git-send-email-eantoranz@gmail.com> On Sat, Dec 12, 2015 at 5:57 PM, Edmundo Carmona Antoranz wrote: > + if (incremental || (output_option & OUTPUT_PORCELAIN)) { > + if (show_progress > 0) > + die("--progress can't be used with --incremental or porcelain formats"); > + show_progress = 0; > + } else if (show_progress < 0) > + show_progress = isatty(2); > + I think I took care of all the comments from Eric gracefully. Hope that block is ok for detection of mutually exclusivity related to --progress. Cheers!