Re: [PATCH] Disallow creating ambiguous branch names by default
- From
Conrad Irwin <conrad.irwin@gmail.com>
- Date
- Aug 19, 2011, 18:07 UTC
- Message-ID
- <CAOTq_ptdf3NvoeQXzdABdnU50w1ZwL=wnF6rPJvZpnqcU64-+g@mail.gmail.com>
- In-Reply-To
- <14776204.81375.1313675595871.JavaMail.root@mail.hq.genarts.com>
On Thu, Aug 18, 2011 at 6:53 AM, Stephen Bash <bash@genarts.com> wrote:
> > Should case insensitive matches be added to the tests? This morning I discovered coworkers working on branches foo and Foo thinking they were on the same branch... Rather trivial to clean up, but certainly caused some confusion in the office. >
I can certainly see the use-case, but there's definitely a step-change between "this branch has the same name as something else", and "this branch is going to confuse you". When trying to change the code to be a warning as Junio suggested, I did think about expanding the definition of ambiguous to include things that are merely confusing; however it's not clear where to stop (i.e. should we warn about <remotename>/<anything>, foo and f00, a branch called " " [the non-breaking space]). There's probably an argument for more general warning, but I don't think I understand when it should be shown well-enough.
Conrad