Re: [PATCH 00/16] refs: drop all references to `the_repository`

From: Karthik Nayak <karthik.188@gmail.com>
Date: May 16, 2024, 18:57 UTC
Message-ID: <CAOLa=ZThWW0ToK3x-GBynSPZ0E_ssKRd_bLH8ayy0QD4gkOGpw@mail.gmail.com>
In-Reply-To: <cover.1715836916.git.ps@pks.im>

Hello,

Patrick Steinhardt <ps@pks.im> writes:

Show 19 quoted lines

> Hi,
>
> in "ps/refs-without-the-repository", we have removed all functions in
> the refs API that could be trivially converted to accept a proper ref
> store as input. This was a mechanical change, and because the resulting
> patches were quite large by themselves already, I decided to push out
> further dependencies on `the_repository` in refs-related code to a
> follow up.
>
> This patch series here is that follow-up and removes all references to
> `the_repository` in "refs.c" and "refs/". This includes both explicit
> use of `the_repository`, but also implicit use via `the_hash_algo`.
>
> The series is based on 19fe900cfc (The fourth batch, 2024-05-15) and
> pulls in "ps/refs-without-the-repository" at c8f815c208 (refs: remove
> functions without ref store, 2024-05-07) as dependency. It applies
> cleanly to both next and seen at the current point in time.
>
> Patrick

The commits here were easy to follow. Apart from some small nits, I don't have any changes to suggest here.

I did confirm we no longer have 'the_repository' anywhere in the refs code. Which is super. BTW, should we also remove the migration code added in refs.h, since 2.45 is now released?

Thanks