git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t: remove unexpected SANITIZE_LEAK variables

From
Karthik Nayak <karthik.188@gmail.com>
Date
May 22, 2025, 09:06 UTC
Message-ID
<CAOLa=ZTg8_Hs0Ysu4bhtp9VZxnDEkSx3MvD1dN2yYYw7DqKRLw@mail.gmail.com>
In-Reply-To
<20250522060933.GA1135565@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 14 quoted lines
> On Thu, May 22, 2025 at 02:06:26AM -0400, Jeff King wrote:
>
>> As a side note, we do still use the SANITIZE_LEAK prereq in a few
>> places, and I believe that it does actually work. It might be nice to
>> clean up any leaks in those few spots, though we probably want to keep
>> the prereq around forever (e.g., if you introduce a test which shows off
>> a leak and then fixes it later). All orthogonal to your patch, though,
>> which looks good to me.
>
> Ah, nevermind. These are all due to 8415595203 (t5601: work around leak
> sanitizer issue, 2024-11-20). They are leak-free (and the tests pass on
> my system), but apparently some upstream bug can cause issues.
>
> -Peff

Yup. Someday in the future we can cleanup the whole thing. That would be nice!

- Karthik
Previous: Jeff King
Message 6 of 6 in “t: remove unexpected SANITIZE_LEAK variables”
  1. t: remove unexpected SANITIZE_LEAK variablesKarthik Nayak, May 20, 2025
  2. Justin ToblerMay 20, 2025
  3. Junio C HamanoMay 20, 2025
  4. Jeff KingMay 22, 2025
  5. Jeff KingMay 22, 2025
  6. Karthik NayakMay 22, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.