Re: [PATCH] t: remove unexpected SANITIZE_LEAK variables

From: Jeff King <peff@peff.net>
Date: May 22, 2025, 06:06 UTC
Message-ID: <20250522060626.GB1137854@coredump.intra.peff.net>
In-Reply-To: <20250520-kn-remove-unexpected-exported-v1-1-bb60cec57e84@gmail.com>

On Tue, May 20, 2025 at 04:40:12PM +0200, Karthik Nayak wrote:

Show 5 quoted lines

> As of 1fc7ddf35b (test-lib: unconditionally enable leak checking,
> 2024-11-20), both the `GIT_TEST_PASSING_SANITIZE_LEAK` and
> `TEST_PASSES_SANITIZE_LEAK` variables no longer have any meaning, the
> leak checks are enabled by default. However, some newly added tests
> include them by mistake. Let's clean this up.

Thanks, I saw these recently while looking at another topic and was surprised. I hadn't yet confirmed that they truly are pointless, so I'm glad that you did. :)

As a side note, we do still use the SANITIZE_LEAK prereq in a few places, and I believe that it does actually work. It might be nice to clean up any leaks in those few spots, though we probably want to keep the prereq around forever (e.g., if you introduce a test which shows off a leak and then fixes it later). All orthogonal to your patch, though, which looks good to me.

-Peff