git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v8 0/11] Port tag.c over to use ref-filter APIs

From
Karthik Nayak <karthik.188@gmail.com>
Date
Aug 3, 2015, 22:13 UTC
Message-ID
<CAOLa=ZTf-rQuc_Hv=8NnYx_j8YGJuYNmOa+nz=MeoxAK6JFU3Q@mail.gmail.com>
In-Reply-To
<xmqq7fpc6n5o.fsf@gitster.dls.corp.google.com>
On Tue, Aug 4, 2015 at 3:38 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 19 quoted lines
> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> On Tue, Aug 4, 2015 at 1:51 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> ...
>>> It is very very dissapointing to allow the "next atom only"
>>> implementation to squat on a good name "align:<type>,<width>",
>>> especially when I thought that the list agreed
>>>
>>>   %(align:<type>,<width>) any string with or without %(atom) %(end)
>>>
>>> would be the way to go.
>>
>> From what I read, I thought we wanted the next atom or string to be
>> aligned, if we need to align everything within the %(end) atom.
>
> Is that a serious comment?
>
> Did I read too much into your $gmane/275119, expecting that you
> understood everything you are saying "That's a good way to go" to?

Sorry, I kinda was thinking only WRT to the %(if) and %(end) part of it. Even though you clearly mentioned about %(align) also.

>
>> I could do that :)
>
> Sure ;-)

I have it ready, will wait to see if there are more comments and send with next iteration of the series.

-- 
Regards,
Karthik Nayak
Previous: Junio C Hamano
Message 20 of 20 in “Port tag.c over to use ref-filter APIs”
  1. 0/11 Port tag.c over to use ref-filter APIsKarthik Nayak, Aug 3, 2015
  2. 01/11 ref-filter: print output to strbuf for formattingKarthik Nayak, Aug 3, 2015
  3. Junio C HamanoAug 3, 2015
  4. Karthik NayakAug 3, 2015
  5. 02/11 ref-filter: introduce ref_formatting_stateKarthik Nayak, Aug 3, 2015
  6. Junio C HamanoAug 3, 2015
  7. Karthik NayakAug 3, 2015
  8. 03/11 ref-filter: implement an `align` atomKarthik Nayak, Aug 3, 2015
  9. 04/11 ref-filter: add option to filter only tagsKarthik Nayak, Aug 3, 2015
  10. 05/11 ref-filter: support printing N lines from tag annotationKarthik Nayak, Aug 3, 2015
  11. 06/11 ref-filter: add support to sort by versionKarthik Nayak, Aug 3, 2015
  12. 07/11 ref-filter: add option to match literal patternKarthik Nayak, Aug 3, 2015
  13. 08/11 tag.c: use 'ref-filter' data structuresKarthik Nayak, Aug 3, 2015
  14. 09/11 tag.c: use 'ref-filter' APIsKarthik Nayak, Aug 3, 2015
  15. 10/11 tag.c: implement '--format' optionKarthik Nayak, Aug 3, 2015
  16. 11/11 tag.c: implement '--merged' and '--no-merged' optionsKarthik Nayak, Aug 3, 2015
  17. Junio C HamanoAug 3, 2015
  18. Karthik NayakAug 3, 2015
  19. Junio C HamanoAug 3, 2015
  20. Karthik NayakAug 3, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.