git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v8 04/11] ref-filter: add option to filter only tags

From
Karthik Nayak <karthik.188@gmail.com>
Date
Aug 3, 2015, 16:54 UTC
Message-ID
<1438620861-25219-4-git-send-email-Karthik.188@gmail.com>
In-Reply-To
<CAOLa=ZTYWTjc-OC7N7FGWETP1svpCkqhQ2wwPmbf5nVRyPRAqg@mail.gmail.com>
From: Karthik Nayak <karthik.188@gmail.com>

Add a functions called 'for_each_tag_ref_fullpath()' to refs.{c,h} which iterates through each tag ref without trimming the path.

Add an option in 'filter_refs()' to use 'for_each_tag_ref_fullpath()' and filter refs. This type checking is done by adding a 'FILTER_REFS_TAGS' in 'ref-filter.h'

Mentored-by: Christian Couder <christian.couder@gmail.com>
Mentored-by: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
---
 ref-filter.c | 2 ++
 ref-filter.h | 1 +
 refs.c       | 5 +++++
 refs.h       | 1 +
 4 files changed, 9 insertions(+)
diff --git a/ref-filter.c b/ref-filter.c
index 46d8834..01c9097 100644
--- a/ref-filter.c
+++ b/ref-filter.c
@@ -1155,6 +1155,8 @@ int filter_refs(struct ref_array *array, struct ref_filter *filter, unsigned int
 		ret = for_each_rawref(ref_filter_handler, &ref_cbdata);
 	else if (type & FILTER_REFS_ALL)
 		ret = for_each_ref(ref_filter_handler, &ref_cbdata);
+	else if (type & FILTER_REFS_TAGS)
+		ret = for_each_tag_ref_fullpath(ref_filter_handler, &ref_cbdata);
 	else if (type)
 		die("filter_refs: invalid type");
 
diff --git a/ref-filter.h b/ref-filter.h
index 01f8cb3..8d4e348 100644
--- a/ref-filter.h
+++ b/ref-filter.h
@@ -15,6 +15,7 @@
 
 #define FILTER_REFS_INCLUDE_BROKEN 0x1
 #define FILTER_REFS_ALL 0x2
+#define FILTER_REFS_TAGS 0x4
 
 #define ALIGN_LEFT 0x01
 #define ALIGN_RIGHT 0x02
diff --git a/refs.c b/refs.c
index 0b96ece..23ce483 100644
--- a/refs.c
+++ b/refs.c
@@ -2108,6 +2108,11 @@ int for_each_tag_ref(each_ref_fn fn, void *cb_data)
 	return for_each_ref_in("refs/tags/", fn, cb_data);
 }
 
+int for_each_tag_ref_fullpath(each_ref_fn fn, void *cb_data)
+{
+	return do_for_each_ref(&ref_cache, "refs/tags/", fn, 0, 0, cb_data);
+}
+
 int for_each_tag_ref_submodule(const char *submodule, each_ref_fn fn, void *cb_data)
 {
 	return for_each_ref_in_submodule(submodule, "refs/tags/", fn, cb_data);
diff --git a/refs.h b/refs.h
index e4e46c3..9eee2de 100644
--- a/refs.h
+++ b/refs.h
@@ -174,6 +174,7 @@ extern int head_ref(each_ref_fn fn, void *cb_data);
 extern int for_each_ref(each_ref_fn fn, void *cb_data);
 extern int for_each_ref_in(const char *prefix, each_ref_fn fn, void *cb_data);
 extern int for_each_tag_ref(each_ref_fn fn, void *cb_data);
+extern int for_each_tag_ref_fullpath(each_ref_fn fn, void *cb_data);
 extern int for_each_branch_ref(each_ref_fn fn, void *cb_data);
 extern int for_each_remote_ref(each_ref_fn fn, void *cb_data);
 extern int for_each_replace_ref(each_ref_fn fn, void *cb_data);
-- 
2.4.6
Previous: Karthik NayakNext: Karthik Nayak
Message 9 of 20 in “Port tag.c over to use ref-filter APIs”
  1. 0/11 Port tag.c over to use ref-filter APIsKarthik Nayak, Aug 3, 2015
  2. 01/11 ref-filter: print output to strbuf for formattingKarthik Nayak, Aug 3, 2015
  3. Junio C HamanoAug 3, 2015
  4. Karthik NayakAug 3, 2015
  5. 02/11 ref-filter: introduce ref_formatting_stateKarthik Nayak, Aug 3, 2015
  6. Junio C HamanoAug 3, 2015
  7. Karthik NayakAug 3, 2015
  8. 03/11 ref-filter: implement an `align` atomKarthik Nayak, Aug 3, 2015
  9. 04/11 ref-filter: add option to filter only tagsKarthik Nayak, Aug 3, 2015
  10. 05/11 ref-filter: support printing N lines from tag annotationKarthik Nayak, Aug 3, 2015
  11. 06/11 ref-filter: add support to sort by versionKarthik Nayak, Aug 3, 2015
  12. 07/11 ref-filter: add option to match literal patternKarthik Nayak, Aug 3, 2015
  13. 08/11 tag.c: use 'ref-filter' data structuresKarthik Nayak, Aug 3, 2015
  14. 09/11 tag.c: use 'ref-filter' APIsKarthik Nayak, Aug 3, 2015
  15. 10/11 tag.c: implement '--format' optionKarthik Nayak, Aug 3, 2015
  16. 11/11 tag.c: implement '--merged' and '--no-merged' optionsKarthik Nayak, Aug 3, 2015
  17. Junio C HamanoAug 3, 2015
  18. Karthik NayakAug 3, 2015
  19. Junio C HamanoAug 3, 2015
  20. Karthik NayakAug 3, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.