Re: [PATCH 2/2] refs: add GIT_REF_URI to specify reference backend and directory
Jean-Noël Avila <jn.avila@free.fr> writes:
Show 24 quoted lines
> On 19/11/2025 at 22:48, Karthik Nayak wrote:
>> ---
>> Documentation/git.adoc | 8 ++++
>> environment.h | 1 +
>> refs.c | 53 +++++++++++++++++++++++-
>> t/meson.build | 1 +
>> t/t1423-ref-backend.sh | 109 +++++++++++++++++++++++++++++++++++++++++++++++++
>> 5 files changed, 171 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/git.adoc b/Documentation/git.adoc
>> index ce099e78b8..a1d1078f42 100644
>> --- a/Documentation/git.adoc
>> +++ b/Documentation/git.adoc
>> @@ -584,6 +584,14 @@ double-quotes and respecting backslash escapes. E.g., the value
>> repositories will be set to this value. The default is "files".
>> See `--ref-format` in linkgit:git-init[1].
>>
>> +`GIT_REF_URI`::
>> + Specify which reference backend and path to be used, if not specified the
>> + backend is inferred from the configuration and $GIT_DIR is used as the
>> + path.
>
> Please use backquotes for environment variables: `$GIT_DIR`
>
Show 14 quoted lines
>> ++
>> +Expects the format '<ref_backend>://<path>', where the 'backend' specifies the
>> +reference backend and the 'path' specifies the directory used by the backend.
>
> Constant strings and keywords are back-quoted too but placeholders are
> underscored:
>
> Expects the format `<ref_backend>://<path>`, where the _<ref_backend>_
> specifies the reference backend and the _<path>_ specifies the directory
> used by the backend.
>
> I'm only focusing on documentation.
>
> Thanks
Thanks for your review, will modify accordingly.