Re: [PATCH v8 5/6] refs: allow reference location in refstorage config
- From
Karthik Nayak <karthik.188@gmail.com>
- Date
- Feb 24, 2026, 13:09 UTC
- Message-ID
- <CAOLa=ZTJ3-7OSbfRYbYuTaZBsPSSXrHHJ5LkCO_HSMw=y5+Gfg@mail.gmail.com>
- In-Reply-To
- <3af8a2ba-dfe4-4e43-8f86-b03a0cbc3698@app.fastmail.com>
"Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com> writes:
Show 61 quoted lines
> On Mon, Feb 23, 2026, at 09:01, Karthik Nayak wrote: >>[snip] >> >> Helped-by: Patrick Steinhardt <ps@pks.im> >> Signed-off-by: Karthik Nayak <karthik.188@gmail.com> >> --- >> Documentation/config/extensions.adoc | 16 +++- >> builtin/worktree.c | 34 ++++++++ >> refs.c | 6 +- >> repository.c | 9 +- >> repository.h | 8 +- >> setup.c | 34 +++++++- >> setup.h | 1 + >> t/meson.build | 1 + >> t/t1423-ref-backend.sh | 159 +++++++++++++++++++++++++++++++++++ >> 9 files changed, 259 insertions(+), 9 deletions(-) >> >> diff --git a/Documentation/config/extensions.adoc >> b/Documentation/config/extensions.adoc >> index 532456644b..3e51da36d3 100644 >> --- a/Documentation/config/extensions.adoc >> +++ b/Documentation/config/extensions.adoc >> @@ -57,10 +57,24 @@ For historical reasons, this extension is respected >> regardless of the >> `core.repositoryFormatVersion` setting. >> >> refStorage::: >> - Specify the ref storage format to use. The acceptable values are: >> + Specify the ref storage format and a corresponding payload. The value >> + can be either a format name or a URI: >> + >> -- >> +* A format name alone (e.g., `reftable` or `files`). >> + >> +* A URI format `<format>://<payload>` explicitly specifies both the >> + format and payload (e.g., `reftable:///foo/bar`). >> + >> +Supported format names are: >> ++ >> include::../ref-storage-format.adoc[] > > It looks like this causes list continuation (+) and the `;;` syntax to > appear in the HTML output of git-config(1). > > + files;; for loose files with packed-refs. ... > > + The payload is passed ... > > According to `Documentation/doc-diff master seen`. > > It looks like dropping the list continuations fixes it. > > Supported format names are: > > include::../ref-storage-format.adoc[] > > The payload is passed directly to the reference backend. For the files and > [...] > > Maybe because you are inside an open block? I don’t know. >
I don't know either. But this seems to fix it, let me know if it does for you too.
--8<--
diff --git a/Documentation/config/extensions.adoc b/Documentation/config/extensions.adoc index 3e51da36d3..329d02b3c4 100644 --- a/Documentation/config/extensions.adoc +++ b/Documentation/config/extensions.adoc @@ -67,13 +67,13 @@ refStorage::: format and payload (e.g., `reftable:///foo/bar`). Supported format names are: -+ + include::../ref-storage-format.adoc[] -+ + The payload is passed directly to the reference backend. For the files and reftable backends, this must be a filesystem path where the references will be stored. Defaulting to the commondir when no payload is provided. Relative -paths are resolved relative to the $GIT_DIR. Future backends may support +paths are resolved relative to the `$GIT_DIR`. Future backends may support other payload schemes, e.g., postgres://127.0.0.1:5432?database=myrepo. -- + >> ++ >> +The payload is passed directly to the reference backend. For the files >>[snip]