Re: [PATCH 1/4] t: fix cases where output breaks TAP format

From: Karthik Nayak <karthik.188@gmail.com>
Date: May 14, 2025, 18:51 UTC
Message-ID: <CAOLa=ZTN2V1DbWRBkhc+JiOeBnPQHNj6zBQwoKnXa-bqBm0NvA@mail.gmail.com>
In-Reply-To: <20250506-pks-meson-tap-v1-1-5aaab2942a4c@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 6 quoted lines

> The TAP format does not allow arbitrary output outside of a specific
> test case. If a test suite wants to print any such diagnostic output,
> then this output has to be prefixed with "#" to mark it accordingly.
> A bunch of our tests generate output outside of `test_expect_*`
> testcases anyway without such a mark, which breaks strict TAP parsers.
>

This is different because `test_expect_*` sets up the stdout and stderr redirection to new file descriptors, but any code outside that wouldn't have that redirection. Okay.

> Upon further inspection, all of the output generated by such tests is
> rather uninteresting. Refactor them so that we don't break the TAP
> format.

The changes make sense WRT to the description.