Re: [PATCH v3 07/10] t7815: fix unexpectedly passing test on macOS

From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date: Jun 1, 2025, 09:19 UTC
Message-ID: <7583b751-5380-41b8-8353-bba2618a0bad@app.fastmail.com>
In-Reply-To: <20250530-pks-meson-tap-v3-7-676f5e41f2e4@pks.im>

On Fri, May 30, 2025, at 15:31, Patrick Steinhardt wrote:

Show 10 quoted lines

> In t7815, we have the following test:
>
>     test_expect_failure !CYGWIN 'git grep .fi a' '
>         git grep .fi a
>     '
>
> The test passes if '.' matches a NUL byte, which we expect to only
> happen on Cygwin. The upcoming changes to support parsing TAP output in
> Meson surface that this test is also unexpectedly passing on macOS
> though.

This last sentence was difficult for me when I first read it. It seems that there are multiple verb tenses and it has many words without any pauses. Maybe consider restructuring with some comma breaks or something.

    The upcoming changes to support parsing TAP output in Meson is
    showing that this test, suprisingly, passes on macOS as well.

> It is unclear how long the test has been passing on macOS already.
> 064eed36c7f (config.mak.uname: only set NO_REGEX on cygwin for v1.7,
> 2025-04-17) mentions that the test started to pass for Cygwin once it
> has imported a newer implementation of

“started to pass” followed by “has imported” doesn’t sound right.

> regcomp(3p) et all, which was

s/et all,/et al.,/