git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 5/8] branch: drop non-commit error reporting

From
Karthik Nayak <karthik.188@gmail.com>
Date
Sep 21, 2015, 11:35 UTC
Message-ID
<CAOLa=ZTJUqu2Y1opZJmuYzvGDRNwD-3-RQ_jvLjs49sgyRpPnw@mail.gmail.com>
In-Reply-To
<CAOLa=ZTYfNN6ATae6pYy1QHPo-u70itz9euHvaWjiayUgKD9GA@mail.gmail.com>
On Mon, Sep 21, 2015 at 3:50 PM, Karthik Nayak <karthik.188@gmail.com> wrote:
Show 26 quoted lines
> On Mon, Sep 21, 2015 at 12:46 AM, Matthieu Moy
> <Matthieu.Moy@grenoble-inp.fr> wrote:
>> Karthik Nayak <karthik.188@gmail.com> writes:
>>
>>> Remove the error reporting variable to make the code easier to port
>>> over to using ref-filter APIs. This variable
>>
>> (it's not just a variable, it's also a message on the output)
>>
>>> is not required as in ref-filter we already check for possible errors
>>> and report them.
>>
>> You should explain more why the check is redundant with the ones in
>> ref-filter. You discussed this with Junio on the last round. The
>> arguments you gave would deserve to appear in the commit message IMHO.
>> Pointing to the exact checks in ref-filter would help.
>>
>> It may make sense to split the commit into several smaller ones, so that
>> you can give a precise commit message for each error reporting you
>> remove (error(_("branch '%s' does not point at a commit") and
>> error(_("some refs could not be read"))).
>>
>
> I could do that, but it would be small changes. But I think it's worth it,
> will wait for other changes if needed and send.
>

But then again, both those are interrelated, the cb.ret value is set at (error(_("branch '%s' does not point at a commit"), refname) and the second error is printed on the basis that the first error set's cb.ret value. So I find it better to modify and commit message and leave the commits united.

-- 
Regards,
Karthik Nayak
Previous: Karthik NayakNext: Karthik Nayak
Message 10 of 19 in “port the filtering part of branch.c to use ref-filter APIs”
  1. 0/8 port the filtering part of branch.c to use ref-filter APIsKarthik Nayak, Sep 20, 2015
  2. 1/8 branch: refactor width computationKarthik Nayak, Sep 20, 2015
  3. 2/8 branch: bump get_head_description() to the topKarthik Nayak, Sep 20, 2015
  4. 3/8 branch: roll show_detached HEAD into regular ref_listKarthik Nayak, Sep 20, 2015
  5. Matthieu MoySep 20, 2015
  6. 4/8 branch: move 'current' check down to the presentation layerKarthik Nayak, Sep 20, 2015
  7. 5/8 branch: drop non-commit error reportingKarthik Nayak, Sep 20, 2015
  8. Matthieu MoySep 20, 2015
  9. Karthik NayakSep 21, 2015
  10. Karthik NayakSep 21, 2015
  11. 6/8 branch.c: use 'ref-filter' data structuresKarthik Nayak, Sep 20, 2015
  12. 7/8 branch.c: use 'ref-filter' APIsKarthik Nayak, Sep 20, 2015
  13. Matthieu MoySep 20, 2015
  14. Karthik NayakSep 21, 2015
  15. 8/8 branch: add '--points-at' optionKarthik Nayak, Sep 20, 2015
  16. Matthieu MoySep 20, 2015
  17. Karthik NayakSep 21, 2015
  18. Matthieu MoySep 21, 2015
  19. Karthik NayakSep 21, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.