Re: [Outreachy PATCH v2 0/2] notes-utils: stop using the_repository

From: Karthik Nayak <karthik.188@gmail.com>
Date: Nov 3, 2026, 09:48 UTC
Message-ID: <CAOLa=ZTAEVcKj-Y5QCGsAFAMUSh665E1fmQrEnuuufTLLbn3Wg@mail.gmail.com>
In-Reply-To: <20261103084930.15532-1-okhuomonajayi54@gmail.com>

Okhuomon Ajayi <okhuomonajayi54@gmail.com> writes:

Show 15 quoted lines

> This series removes the_repository from notes-utils.c.
>
> Changes since v1:
> - Add patch 2, which passes a repository to
>   init_copy_notes_for_rewrite() and drops USE_THE_REPOSITORY_VARIABLE
>   from notes-utils.c, as Patrick suggested. v1 stopped one step short
>   of that.
>
> The callers in builtin/am.c and builtin/notes.c pass the_repository,
> as those files still use it everywhere. copy() in builtin/notes.c
> does receive a repo that could be passed down instead, if that is
> preferred.
>
> Thanks, Patrick, for the review.
>

Overall the patches look good to me.

[snip]