git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[Outreachy PATCH v2 0/2] notes-utils: stop using the_repository

From
OAOkhuomon Ajayi <okhuomonajayi54@gmail.com>
Date
Nov 3, 2026, 08:49 UTC
Message-ID
<20261103084930.15532-1-okhuomonajayi54@gmail.com>
In-Reply-To
<20261031104526.46711-1-okhuomonajayi54@gmail.com>
This series removes the_repository from notes-utils.c.
Changes since v1:
- Add patch 2, which passes a repository to
  init_copy_notes_for_rewrite() and drops USE_THE_REPOSITORY_VARIABLE
  from notes-utils.c, as Patrick suggested. v1 stopped one step short
  of that.

The callers in builtin/am.c and builtin/notes.c pass the_repository, as those files still use it everywhere. copy() in builtin/notes.c does receive a repo that could be passed down instead, if that is preferred.

Thanks, Patrick, for the review.
Okhuomon Ajayi (2):
  notes-utils: use the passed repository for notes refs
  notes-utils: pass the repository to init_copy_notes_for_rewrite()
 builtin/am.c    |  2 +-
 builtin/notes.c |  2 +-
 notes-utils.c   | 11 +++++------
 notes-utils.h   |  3 ++-
 sequencer.c     |  2 +-
 5 files changed, 10 insertions(+), 10 deletions(-)
base-commit: 50fe5cc63f9cd6e89b87a2c9ccf96a444f4cfdb7
-- 
2.56.0
Previous: Okhuomon AjayiNext: Okhuomon Ajayi
Message 4 of 10 in “notes-utils: use the passed repository for notes refs”
  1. notes-utils: use the passed repository for notes refsOkhuomon Ajayi, Oct 31, 2026
  2. Patrick SteinhardtNov 2, 2026
  3. Okhuomon AjayiNov 2, 2026
  4. 0/2 notes-utils: stop using the_repositoryOkhuomon Ajayi, Nov 3, 2026
  5. 1/2 notes-utils: use the passed repository for notes refsOkhuomon Ajayi, Nov 3, 2026
  6. Karthik NayakNov 3, 2026
  7. Junio C HamanoNov 3, 2026
  8. 2/2 notes-utils: pass the repository to init_copy_notes_for_rewrite()Okhuomon Ajayi, Nov 3, 2026
  9. Karthik NayakNov 3, 2026
  10. Patrick SteinhardtNov 3, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.