git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/4] refs/reftable: don't write new table on dry-run expire

From
Karthik Nayak <karthik.188@gmail.com>
Date
Nov 18, 2026, 11:28 UTC
Message-ID
<CAOLa=ZSx=m=5+Jw8JzKXutaYp_mKOWbSsBVTHtMT3rDUk3a=eA@mail.gmail.com>
In-Reply-To
<20261118-pks-reflog-expire-performance-v1-1-10b9263566a8@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 21 quoted lines
> The `git reflog expire` subcommand supports a dry-run flag. When set, we
> print what would be pruned without actually pruning anything on disk.
>
> But even though the expectation is that the on-disk state won't change,
> the reftable backend still ends up writing a new reftable to disk that
> contains the changes. This is of course rather pointless, as we would
> have already printed the entries that we're about to prune at that point
> in time.
>
> Skip writing the data, which provides a small speedup:
>
>   Benchmark 1: git reflog expire --all --dry-run (commit = HEAD~) (10 runs)
>                   mean     ±       σ          min     …     max
>     Wall Time    414.2 ms  ±     2.2 ms     411.8 ms  …   418.0 ms
>     Memory       116.9 MiB ±     0.1 MiB    116.6 MiB …   117.0 MiB
>
>   Benchmark 2: git reflog expire --all --dry-run (commit = HEAD) (10 runs)
>                   mean     ±       σ          min     …     max
>     Wall Time    369.1 ms  ±     3.2 ms     361.9 ms  …   371.9 ms           -10.9%
>     Memory       116.8 MiB ±     0.1 MiB    116.7 MiB …   117.0 MiB           -0.1%
>
Nice find. Obviously the previous flow was wrong.
Show 25 quoted lines
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
>  refs/reftable-backend.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/refs/reftable-backend.c b/refs/reftable-backend.c
> index 3ba6a9ac0db..4216a18684d 100644
> --- a/refs/reftable-backend.c
> +++ b/refs/reftable-backend.c
> @@ -2706,6 +2706,11 @@ static int reftable_be_reflog_expire(struct ref_store *ref_store,
>  	if (flags & EXPIRE_REFLOGS_UPDATE_REF && last_hash && !is_null_oid(&oid))
>  		oidread(&arg.update_oid, last_hash, ref_store->repo->hash_algo);
>
> +	if ((flags & EXPIRE_REFLOGS_DRY_RUN)) {
> +		ret = 0;
> +		goto done;
> +	}
> +
>  	arg.refs = refs;
>  	arg.records = rewritten;
>  	arg.len = logs_nr;
> @@ -2720,8 +2725,7 @@ static int reftable_be_reflog_expire(struct ref_store *ref_store,
>  	 * Future improvement: we could skip writing records that were
>  	 * not changed.
>  	 */
This comment doesn't seem to get removed in the following patch.
> -	if (!(flags & EXPIRE_REFLOGS_DRY_RUN))
> -		ret = reftable_addition_commit(add);
> +	ret = reftable_addition_commit(add);
>
The changes in this patch look sensible.
Show 5 quoted lines
>  done:
>  	if (add)
>
> --
> 2.56.1.831.g720f3f5937.dirty
Previous: Patrick SteinhardtNext: Patrick Steinhardt
Message 3 of 18 in “Improve performance of reflog expiration”
  1. 0/4 Improve performance of reflog expirationPatrick Steinhardt, Nov 18, 2026
  2. 1/4 refs/reftable: don't write new table on dry-run expirePatrick Steinhardt, Nov 18, 2026
  3. Karthik NayakNov 18, 2026
  4. Patrick SteinhardtNov 18, 2026
  5. Junio C HamanoNov 18, 2026
  6. Patrick SteinhardtNov 19, 2026
  7. 2/4 refs/reftable: don't write new table when expire is a no-opPatrick Steinhardt, Nov 18, 2026
  8. Karthik NayakNov 18, 2026
  9. Patrick SteinhardtNov 18, 2026
  10. Toon ClaesNov 18, 2026
  11. Patrick SteinhardtNov 19, 2026
  12. 3/4 builtin/maintenance: only consider `gc.reflogExpire` for "--auto"Patrick Steinhardt, Nov 18, 2026
  13. Toon ClaesNov 18, 2026
  14. Patrick SteinhardtNov 19, 2026
  15. 4/4 Documentation/config: fix typo in "maintenance.reflog-expire.auto"Patrick Steinhardt, Nov 18, 2026
  16. Toon ClaesNov 18, 2026
  17. Toon ClaesNov 18, 2026
  18. Patrick SteinhardtNov 19, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.