git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/4] refs/reftable: don't write new table when expire is a no-op

From
Karthik Nayak <karthik.188@gmail.com>
Date
Nov 18, 2026, 11:33 UTC
Message-ID
<CAOLa=ZQGJkyVY=e94hJVmLa2fuPVUfC3uFRsQTeoa95sUe3UcA@mail.gmail.com>
In-Reply-To
<20261118-pks-reflog-expire-performance-v1-2-10b9263566a8@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 23 quoted lines
> diff --git a/refs/reftable-backend.c b/refs/reftable-backend.c
> index 4216a18684d..e2027bb9c02 100644
> --- a/refs/reftable-backend.c
> +++ b/refs/reftable-backend.c
> @@ -2607,6 +2607,7 @@ static int reftable_be_reflog_expire(struct ref_store *ref_store,
>  	struct strbuf referent = STRBUF_INIT;
>  	uint8_t *last_hash = NULL;
>  	size_t logs_nr = 0, logs_alloc = 0, i;
> +	bool has_changes = false;
>  	unsigned int type = 0;
>  	int ret;
>
> @@ -2696,17 +2697,25 @@ static int reftable_be_reflog_expire(struct ref_store *ref_store,
>  				    logs[i].value.update.message,
>  				    policy_cb_data)) {
>  			dest->value_type = REFTABLE_LOG_DELETION;
> +			has_changes = true;
>  		} else {
> -			if ((flags & EXPIRE_REFLOGS_REWRITE) && last_hash)
> +			if ((flags & EXPIRE_REFLOGS_REWRITE) && last_hash &&
> +			    memcmp(dest->value.update.old_hash, last_hash,
> +				   ref_store->repo->hash_algo->rawsz)) {
>  				memcpy(dest->value.update.old_hash, last_hash, GIT_MAX_RAWSZ);
We can skip this second copy.
Show 10 quoted lines
> +				has_changes = true;
> +			}
>  			last_hash = logs[i].value.update.new_hash;
>  		}
>  	}
>
> -	if (flags & EXPIRE_REFLOGS_UPDATE_REF && last_hash && !is_null_oid(&oid))
> +	if (flags & EXPIRE_REFLOGS_UPDATE_REF && last_hash && !is_null_oid(&oid)) {
>  		oidread(&arg.update_oid, last_hash, ref_store->repo->hash_algo);
> +		if (!oideq(&arg.update_oid, &oid))
We now check if its changed, makes sense.
Show 8 quoted lines
> +			has_changes = true;
> +	}
>
> -	if ((flags & EXPIRE_REFLOGS_DRY_RUN)) {
> +	if (!has_changes || (flags & EXPIRE_REFLOGS_DRY_RUN)) {
>  		ret = 0;
>  		goto done;
>  	}
Nit: it would be nice to mention that we exit early to skip writing any
new tables.
Show 37 quoted lines
> diff --git a/t/t0610-reftable-basics.sh b/t/t0610-reftable-basics.sh
> index a7027458395..d808f1887f6 100755
> --- a/t/t0610-reftable-basics.sh
> +++ b/t/t0610-reftable-basics.sh
> @@ -912,6 +912,36 @@ test_expect_success 'reflog: expiry empties reflog' '
>  	)
>  '
>
> +test_expect_success 'reflog: expiry without changes does not write tables' '
> +	test_when_finished "rm -rf repo" &&
> +	git init repo &&
> +	(
> +		cd repo &&
> +
> +		test_commit A &&
> +		test_commit B &&
> +		test_commit C &&
> +		cp .git/reftable/tables.list expect &&
> +
> +		git reflog expire --all --expire=never --expire-unreachable=never &&
> +		test_cmp expect .git/reftable/tables.list &&
> +
> +		git reflog expire --all --rewrite \
> +			--expire=never --expire-unreachable=never &&
> +		test_cmp expect .git/reftable/tables.list &&
> +
> +		git reflog expire --all --updateref \
> +			--expire=never --expire-unreachable=never &&
> +		test_cmp expect .git/reftable/tables.list &&
> +
> +		git reflog expire --all --dry-run --expire=all &&
> +		test_cmp expect .git/reftable/tables.list &&
> +
> +		git reflog expire --all --expire=all &&
> +		! test_cmp expect .git/reftable/tables.list
> +	)
> +'
Nice. Could we add a similar test for the previous patch too?
Previous: Patrick SteinhardtNext: Patrick Steinhardt
Message 8 of 18 in “Improve performance of reflog expiration”
  1. 0/4 Improve performance of reflog expirationPatrick Steinhardt, Nov 18, 2026
  2. 1/4 refs/reftable: don't write new table on dry-run expirePatrick Steinhardt, Nov 18, 2026
  3. Karthik NayakNov 18, 2026
  4. Patrick SteinhardtNov 18, 2026
  5. Junio C HamanoNov 18, 2026
  6. Patrick SteinhardtNov 19, 2026
  7. 2/4 refs/reftable: don't write new table when expire is a no-opPatrick Steinhardt, Nov 18, 2026
  8. Karthik NayakNov 18, 2026
  9. Patrick SteinhardtNov 18, 2026
  10. Toon ClaesNov 18, 2026
  11. Patrick SteinhardtNov 19, 2026
  12. 3/4 builtin/maintenance: only consider `gc.reflogExpire` for "--auto"Patrick Steinhardt, Nov 18, 2026
  13. Toon ClaesNov 18, 2026
  14. Patrick SteinhardtNov 19, 2026
  15. 4/4 Documentation/config: fix typo in "maintenance.reflog-expire.auto"Patrick Steinhardt, Nov 18, 2026
  16. Toon ClaesNov 18, 2026
  17. Toon ClaesNov 18, 2026
  18. Patrick SteinhardtNov 19, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.