Re: [PATCH v11 12/13] tag.c: implement '--format' option

From: Karthik Nayak <karthik.188@gmail.com>
Date: Aug 17, 2015, 19:14 UTC
Message-ID: <CAOLa=ZSvJ7WO9XADUtZkm=QK6S3n1KRcG4nLpPLKnZUxQ+BrJQ@mail.gmail.com>
In-Reply-To: <xmqqwpwtd9d0.fsf@gitster.dls.corp.google.com>

On Tue, Aug 18, 2015 at 12:34 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 18 quoted lines

> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> From: Karthik Nayak <karthik.188@gmail.com>
>>
>> Implement the '--format' option provided by 'ref-filter'.
>> This lets the user list tags as per desired format similar
>> to the implementation in 'git for-each-ref'.
>>
>> Add tests and documentation for the same.
>
> Hmm, do we want "--format" added to "tag -l" and "branch -l" in the
> first place?  Scriptors should be using "for-each-ref" plumbing in
> the first place, and the point of unifying these three is to share
> filtering features among them, which would make "for-each-ref" able
> to express what the other two can do.  I'd hesitate to add too much
> flexibility to "branch -l" and "tag -l" Porcelains to entice people
> to script around them.
>

I'll leave that decision to you, but I see it as a good feature, when perhaps I just want to list tags with authors. Agreed `for-each-ref` can handle this too but I don't see why `tag -l` shouldn't.

-- 
Regards,
Karthik Nayak