Re: [PATCH v11 12/13] tag.c: implement '--format' option

From: Jacob Keller <jacob.keller@gmail.com>
Date: Aug 17, 2015, 21:38 UTC
Message-ID: <CA+P7+xr5C2DfAKtb-BDKUGW=4LB4ZRfO6wg=N-8APVNaCEgR5Q@mail.gmail.com>
In-Reply-To: <CAOLa=ZSvJ7WO9XADUtZkm=QK6S3n1KRcG4nLpPLKnZUxQ+BrJQ@mail.gmail.com>

On Mon, Aug 17, 2015 at 12:14 PM, Karthik Nayak <karthik.188@gmail.com> wrote:

Show 27 quoted lines

> On Tue, Aug 18, 2015 at 12:34 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> Karthik Nayak <karthik.188@gmail.com> writes:
>>
>>> From: Karthik Nayak <karthik.188@gmail.com>
>>>
>>> Implement the '--format' option provided by 'ref-filter'.
>>> This lets the user list tags as per desired format similar
>>> to the implementation in 'git for-each-ref'.
>>>
>>> Add tests and documentation for the same.
>>
>> Hmm, do we want "--format" added to "tag -l" and "branch -l" in the
>> first place?  Scriptors should be using "for-each-ref" plumbing in
>> the first place, and the point of unifying these three is to share
>> filtering features among them, which would make "for-each-ref" able
>> to express what the other two can do.  I'd hesitate to add too much
>> flexibility to "branch -l" and "tag -l" Porcelains to entice people
>> to script around them.
>>
>
> I'll leave that decision to you, but I see it as a good feature, when perhaps
> I just want to list tags with authors. Agreed `for-each-ref` can handle this too
> but I don't see why `tag -l` shouldn't.
>
> --
> Regards,
> Karthik Nayak

I agree with Karthik,it doesn't really hurt to add it to tag, and will allow users who aren't familiar with for-each-ref to be able to get the --format for some use cases. I think it would increase visibility and use of the format option if it's available on tag and branch.

Regards, Jake