Re: [PATCH v2] reftable/stack: adjust permissions of compacted tables

From: Karthik Nayak <karthik.188@gmail.com>
Date: Jan 25, 2024, 13:05 UTC
Message-ID: <CAOLa=ZSDRr8v0uo2aCtdnbv0F=cFMQymnNLMTzpUt-OCdh5NMA@mail.gmail.com>
In-Reply-To: <b2fb6f5ad0c558527341bd8040544d6b0ae5d8a2.1706100744.git.ps@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 14 quoted lines

> When creating a new compacted table from a range of preexisting ones we
> don't set the default permissions on the resulting table when specified
> by the user. This has the effect that the "core.sharedRepository" config
> will not be honored correctly.
>
> Fix this bug and add a test to catch this issue.
>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
>
> Ugh, I totally forgot about the fact that fchmod(3P) isn't actually
> available on Windows. I've thus evicted the first patch and changed the
> second patch to use chmod(3P) instead. Too bad.
>

Good catch. This version looks good to me! Nothing to add :)