Re: [PATCH v3] reftable/stack: adjust permissions of compacted tables

From: Justin Tobler <jltobler@gmail.com>
Date: Jan 30, 2024, 16:56 UTC
Message-ID: <CAGAWz+7enErUf9apL9nE13=bWSHL=Sz6PdUQ_DRH7-9NCvQ8Fw@mail.gmail.com>
In-Reply-To: <a211818108053754aca002726d0206623a347952.1706263589.git.ps@pks.im>

On Fri, Jan 26, 2024 at 4:09 AM Patrick Steinhardt <ps@pks.im> wrote:

Show 19 quoted lines

>
> When creating a new compacted table from a range of preexisting ones we
> don't set the default permissions on the resulting table when specified
> by the user. This has the effect that the "core.sharedRepository" config
> will not be honored correctly.
>
> Fix this bug and add a test to catch this issue. Note that we only test
> on non-Windows platforms because Windows does not use POSIX permissions
> natively.
>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
>
> Changes compared to v2:
>
>   - Extended the commit message to say why we don't test on Windows
>     systems.
>
>   - Renamed the `scratch` variable to `path`.

Thanks Patrick! This version looks good to me. I have nothing else to add

-Justin