Re: [PATCH 09/11] t-reftable-record: add index tests for reftable_record_is_deletion()

From: Karthik Nayak <karthik.188@gmail.com>
Date: Jun 26, 2024, 11:59 UTC
Message-ID: <CAOLa=ZRqPDicF+vPgRifntz1AKASTooToBzSd6v5bb1hSOOc3Q@mail.gmail.com>
In-Reply-To: <CA+J6zkQ4z6AWsy2uxMQfmtjqN0b_i1njR_a5agcQrnd4o6tmsw@mail.gmail.com>

Chandra Pratap <chandrapratap3519@gmail.com> writes:

Show 13 quoted lines

> On Tue, 25 Jun 2024 at 14:49, Karthik Nayak <karthik.188@gmail.com> wrote:
>>
>> Chandra Pratap <chandrapratap3519@gmail.com> writes:
>>
>> > reftable_record_is_deletion() is a function defined in
>> > reftable/record.{c, h} that determines whether a record is of
>> > type deletion or not. In the current testing setup, this function
>>
>> Nit: 'In the current testing setup' holds true for the series, but on a
>> commit level, this statement needs to be modified with each tackled
>> type.
>
> I'm not quite sure I follow. Could you explain this a bit further?

Patch 06/11 says "In the current testing setup, this function is left untested for all the four record types (ref, log, obj, index)." then it proceeds to add tests for the 'index' type.

However 07/11 still says "In the current testing setup, this function is left untested for all the four record types (ref, log, obj, index).", which is no longer the state. Since we tackled 'index' in the previous commit. So forth for the next two commits.