Re: [GSoC][PATCH 0/11] t: port reftable/record_test.c to the unit testing framework
- From
Karthik Nayak <karthik.188@gmail.com>
- Date
- Jun 25, 2024, 09:32 UTC
- Message-ID
- <CAOLa=ZR=jProEJYnTj0w0=gNyvz8PceVhjXKc+6sQFfUcW=v-Q@mail.gmail.com>
- In-Reply-To
- <20240621115708.3626-1-chandrapratap3519@gmail.com>
Chandra Pratap <chandrapratap3519@gmail.com> writes:
Hello Chandra,
Show 10 quoted lines
> In the recent codebase update (commit 8bf6fbd, 2023-12-09), a new unit
> testing framework written entirely in C was introduced to the Git project
> aimed at simplifying testing and reducing test run times.
> Currently, tests for the reftable refs-backend are performed by a custom
> testing framework defined by reftable/test_framework.{c, h}. Port
> reftable/record_test.c to the unit testing framework and improve upon
> the ported test.
>
> The first patch in the series moves the test to the unit testing framework,
> and the rest of the patches improve upon the ported test.I did review the series, I must say I'm not too familiar with the 'unit-tests' framework, so most of this code was new for me.
Tangential to this GSoC project, I was hoping for some documentation regarding writing/running 'unit-tests', something similar to how we have 't/README'. This would help formalize expected styling and tips around writing tests, and also how to run individual tests. I was mostly able to figure it out from the makefiles, but it would be easier if there was documentation too. (We did discuss this internally, but I think it's worthwhile stating on the list).